Add support to upgrade node pools in place #3610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node pool recreation should be done by creating a new pool and then deleting the old one. WIth static names this cannot be done. [static] Signed-off-by: Nicu Reut <nicu.reut@digitalasset.com>
martinflorian-da
approved these changes
Jan 20, 2026
Contributor
martinflorian-da
left a comment
martinflorian-da
left a comment
There was a problem hiding this comment.
Thanks!
My understanding is that once we apply this it will recreate the node pool with a new name... and that this will just work because we don't actually care for the name. Shout pls if I got this wrong :)
Contributor
Author
|
Exactly, we can actually create how many pools we want with what names we want, only the taints matter |
nicu-da
added a commit
that referenced
this pull request
Jan 20, 2026
This reverts commit 339a4af. [force] Signed-off-by: Nicu Reut <nicu.reut@digitalasset.com>
nicu-da
added a commit
that referenced
this pull request
Jan 20, 2026
nicu-da
added a commit
that referenced
this pull request
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node pool recreation should be done by creating a new pool and then deleting the old one. WIth static names this cannot be done.
[static]
add support for https://github.com/DACH-NY/canton-network-internal/issues/3139
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines